On Wed, Apr 03, 2024 at 08:50:52AM +0200, Hannes Reinecke wrote: >> +++ b/include/scsi/scsi_transport_fc.h >> @@ -709,6 +709,7 @@ struct fc_function_template { >> int (*vport_delete)(struct fc_vport *); >> /* bsg support */ >> + u32 max_bsg_segments; >> int (*bsg_request)(struct bsg_job *); >> int (*bsg_timeout)(struct bsg_job *); >> > That looks like an odd alignment... With alignment do you mean the indentation? It matches that of other non-function pointer fields in this structure.