Hi Sato-san, Thanks for your patch! On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > SH7750 CPG Clock output define. Please improve the patch description. > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/renesas,sh7750-cpg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SH7750/7751 Clock Pulse Generator (CPG) > + > +maintainers: > + - Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > + > +description: > + The Clock Pulse Generator (CPG) generates core clocks for the SoC. It > + includes PLLs, and variable ratio dividers. > + > + The CPG may also provide a Clock Domain for SoC devices, in combination with > + the CPG Module Stop (MSTP) Clocks. > + > +properties: > + compatible: > + enum: > + - renesas,sh7750-cpg # SH7750 > + - renesas,sh7750s-cpg # SH775S > + - renesas,sh7750r-cpg # SH7750R > + - renesas,sh7751-cpg # SH7751 > + - renesas,sh7751r-cpg # SH7751R > + > + reg: true > + > + reg-names: true > + > + clocks: true clocks: maxItems: 1 > + > + clock-names: true clock-names: const: extal > +examples: > + - | > + #include <dt-bindings/clock/sh7750-cpg.h> > + cpg: clock-controller@ffc00000 { > + #clock-cells = <1>; > + #power-domain-cells = <0>; > + compatible = "renesas,sh7751r-cpg"; > + clocks = <&xtal>; > + clock-names = "xtal"; "extal" "xtal" is an output pin, connected to a crystal resonator. "extal" is the clock input put (either crystal resonator or exteral clock input. > + reg = <0xffc00000 20>, <0xfe0a0000 16>; > + reg-names = "FRQCR", "CLKSTP00"; > + renesas,mode = <0>; > + }; > diff --git a/include/dt-bindings/clock/sh7750-cpg.h b/include/dt-bindings/clock/sh7750-cpg.h > new file mode 100644 > index 000000000000..17d5a8076aac > --- /dev/null > +++ b/include/dt-bindings/clock/sh7750-cpg.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + * > + * Copyright 2023 Yoshinori Sato > + */ > + > +#ifndef __DT_BINDINGS_CLOCK_SH7750_H__ > +#define __DT_BINDINGS_CLOCK_SH7750_H__ > + > +#define SH7750_CPG_PLLOUT 0 > + > +#define SH7750_CPG_FCK 1 PCK? > +#define SH7750_CPG_BCK 2 > +#define SH7750_CPG_ICK 3 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
