On 2/14/24 22:00, Niklas Cassel wrote: > Most quirks are applied using a specific board type board_ahci_no* > (e.g. board_ahci_nomsi, board_ahci_noncq), which then sets a flag > representing the specific quirk. > > ahci_pci_tbl (which is the table of all supported PCI devices), then > uses that board type for the PCI vendor and device IDs which need to > be quirked. > > The ahci_broken_devslp quirk is not implemented in this standard way. > > Modify the ahci_broken_devslp quirk to be implemented like the other > quirks. This way, we will not have the same PCI device and vendor ID > scattered over ahci.c. It will simply be defined in a single location. > > Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> Looks good. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research