Niklas Cassel <cassel@xxxxxxxxxx> 於 2024年2月7日 週三 上午5:14寫道：
>
> There is no need for ahci_update_initial_lpm_policy() to take hpriv as a
> parameter, it can easily be derived from the ata_port.
>
> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
> ---
> drivers/ata/ahci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 4d3ec6d15ad1..346a0f9ef246 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1655,9 +1655,9 @@ static void ahci_mark_external_port(struct ata_port *ap)
> ap->pflags |= ATA_PFLAG_EXTERNAL;
> }
>
> -static void ahci_update_initial_lpm_policy(struct ata_port *ap,
> - struct ahci_host_priv *hpriv)
> +static void ahci_update_initial_lpm_policy(struct ata_port *ap)
> {
> + struct ahci_host_priv *hpriv = ap->host->private_data;
> int policy = CONFIG_SATA_MOBILE_LPM_POLICY;
>
>
> @@ -1949,7 +1949,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> ahci_mark_external_port(ap);
>
> - ahci_update_initial_lpm_policy(ap, hpriv);
> + ahci_update_initial_lpm_policy(ap);
>
> /* disabled/not-implemented port */
> if (!(hpriv->port_map & (1 << i)))
> --
> 2.43.0
>
Acked-by: Jian-Hong Pan <jhp@xxxxxxxxxxxxx>
