Thu, Jan 18, 2024 at 11:21:05AM +0300, Nikita Shubin kirjoitti:
> - add OF ID match table
> - drop platform DMA and filters
> - change DMA setup to OF, so we can defer probe
...
> + drv_data->dma_rx_channel = dma_request_chan(dev, "rx");
> + if (IS_ERR(drv_data->dma_rx_channel)) {
> + ret = PTR_ERR(drv_data->dma_rx_channel);
> + return dev_err_probe(dev, ret, "rx DMA setup failed\n");
It can be done in one statement:
return dev_err_probe(dev, PTR_ERR(drv_data->dma_rx_channel),
"rx DMA setup failed\n");
> + }
...
> + drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx");
> + if (IS_ERR(drv_data->dma_tx_channel)) {
> + ret = PTR_ERR(drv_data->dma_tx_channel);
> + dev_err_probe(dev, ret, "tx DMA setup failed\n");
In the similar way
ret = dev_err_probe(...);
> + goto fail_release_rx;
> }
--
With Best Regards,
Andy Shevchenko
