Damien Le Moal <dlemoal@xxxxxxxxxx> writes: > The comment should also be improved. It is more than a "no need" given that a > sleeping disk will not respond to any command... So something like: Good point. > /* > * If the devices is in SLEEP state, issuing a STANDBY IMMEDIATE > * command will fail. But given that the drive is already in a low > * power state, we do not need to do anything. > */ It didn't fail, it just caused the drive to spin up, only to spin right back down again. > Other than the above comments, this looks OK. And this probably should go first > in the series with a fixes tag. I'm not sure what I'd point a fixes tag at. I think it's been this way forever. Well, at least as long as SLEEP support has been in, which is basically forever.
