On Tue, Dec 12, 2023 at 11:20:53AM +0300, Nikita Shubin wrote:
> Drop legacy acquire/release since we are using pinctrl for this now.
...
> - if (IS_ERR(drv_data->dma_rx_channel)) {
> + if (PTR_ERR_OR_ZERO(drv_data->dma_rx_channel)) {
This seems incorrect.
> ret = PTR_ERR(drv_data->dma_rx_channel);
> return dev_err_probe(dev, ret, "rx DMA setup failed");
return dev_err_probe(...);
> }
I think you wanted
ret = PTR_ERR_OR_ZERO(drv_data->dma_rx_channel);
if (ret)
return dev_err_probe(dev, ret, "rx DMA setup failed");
...
> drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx");
> - if (IS_ERR(drv_data->dma_tx_channel)) {
> + if (PTR_ERR_OR_ZERO(drv_data->dma_tx_channel)) {
> ret = PTR_ERR(drv_data->dma_tx_channel);
> dev_err_probe(dev, ret, "tx DMA setup failed");
> goto fail_release_rx;
Ditto.
--
With Best Regards,
Andy Shevchenko
