On Thu, 26 Oct 2023 at 21:31, Damien Le Moal <dlemoal@xxxxxxxxxx> wrote:
>
> A single patch to fix a regression introduced by the recent
> suspend/resume fixes. The regression is that ATA disks are not stopped
> on system shutdown, which is not recommended and increases the disks
> SMART counters for unclean power off events. This patch fixes this by
> refining the recent rework of the scsi device manage_xxx flags.
Side note: I think 'bool' ends up always using a whole byte in 'struct
scsi_device' (because you can't take an address of a single bit).
And while it might all end up being unnoticeable due to padding, those
bools are right next to bitfields.
Which just makes me go "those should all have been just 'unsigned:1' fields".
Of course, maybe they actually have their address taken, and it's all
very intentional.
Linus
