Hi Haonan, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Haonan-Li/pata_lagacy-Handle-failed-ATA-timing-computation-in-opti82c46x_set_piomode/20231018-073451 base: linus/master patch link: https://lore.kernel.org/r/20231017233234.2170437-1-lihaonan1105%40gmail.com patch subject: [PATCH] pata_lagacy: Handle failed ATA timing computation in opti82c46x_set_piomode reproduce: (https://download.01.org/0day-ci/archive/20231018/202310180858.o7Wjw0A2-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310180858.o7Wjw0A2-lkp@xxxxxxxxx/ # many are suggestions rather than must-fix WARNING:BRACES: braces {} are not necessary for single statement blocks #31: FILE: drivers/ata/pata_legacy.c:582: + if (ata_timing_compute(adev, adev->pio_mode, &t, clock, 1000)) { + return; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #39: FILE: drivers/ata/pata_legacy.c:589: + if (ata_timing_compute(pair, pair->pio_mode, &tp, clock, 1000)) { + return; + } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
