On Fri, Oct 13, 2023 at 11:14:09AM -0400, Phillip Susi wrote: > Damien Le Moal <dlemoal@xxxxxxxxxx> writes: > > /** > > * ata_dev_power_set_active - Set a device power mode to active > > * @dev: target device > > @@ -2065,6 +2092,13 @@ void ata_dev_power_set_active(struct ata_device *dev) > > if (!ata_dev_power_init_tf(dev, &tf, true)) > > return; > > > > + /* > > + * Check the device power state & condition and force a spinup with > > + * VERIFY command only if the drive is not already ACTIVE or IDLE. > > + */ > > + if (ata_dev_power_is_active(dev)) > > + return; > > + > > ata_dev_notice(dev, "Entering active power mode\n"); > > > > err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0); > > This bit didn't apply cleanly to what I just pulled from Linus. It > seems there are soem differences in how the tf is set up. Why not move > this check to before the tf is set up? There isn't much point in > setting it up if it isn't going to be used. Hello Phillip, This series applies cleanly to: https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git/log/?h=for-next The for-next branch also has a bunch of suspend/resume patches that will not go in to v6.6. Kind regards, Niklas
