Hi Damien, On Wed, Sep 20, 2023 at 3:54 PM Damien Le Moal <dlemoal@xxxxxxxxxx> wrote: > The first 9 patches of this series fix several issues with suspend/resume > power management operations in scsi and libata. The most significant > changes introduced are in patch 4 and 5, where the manage_start_stop > flag of scsi devices is split into the manage_system_start_stop and > manage_runtime_start_stop flags to allow keeping scsi runtime power > operations for spining up/down ATA devices but have libata do its own > system suspend/resume device power state management using EH. > > The remaining patches are code cleanup that do not introduce any > significant functional change. > > This series was tested on qemu and on various PCs and servers. I am > CC-ing people who recently reported issues with suspend/resume. > Additional testing would be much appreciated. > > Changes from v3: > * Corrected pathc 1 (typo in commit message and WARN_ON() removal) > * Changed path 3 as suggested by Niklas (moved definition of > ->slave_alloc) > * Rebased on rc2 > * Added review tags Thanks for the update! I gave this a try on Renesas Salvator-XS with R-Car H3 ES2.0 and a SATA hard drive: - The drive is spun up during system resume, - Accessing the drive after the system was resumed is instantaneous. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds