Re: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Pawel,

On Fri, Sep 01, 2023 at 11:23:17AM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> ---
> V1 -> V2: Fixed formatting.
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)

I think you forgot your Signed-off-by tag this time.

See:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

E.g.

<commit message>
...
Signed-off-by: Author <author@mail>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments

path/to/file | 5+++--
...


If you run ./scripts/checkpatch.pl against your patch,
it should tell you if the Signed-off-by tag is missing.


Kind regards,
Niklas



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux