Re: [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Damien!

On Thu, 2023-08-24 at 08:07 +0900, Damien Le Moal wrote:
> On 8/23/23 18:47, Nikita Shubin via B4 Relay wrote:
> > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> > 
> > Return -ENOMEM from ep93xx_pata_probe() if devm_kzalloc() or
> > ata_host_alloc() fails.
> > 
> > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> 
> Doesn't this need a Fixes tag and Cc: stable ?
> 
> This is not really a bug fix, but might as well be complete with the
> fix :)

Well... This would be fix for:

```
commit 2fff27512600f9ad91335577e485a8552edb0abf
Author: Rafal Prylowski <prylowski@xxxxxxxxxxx>
Date:   Thu Apr 12 14:13:16 2012 +0200
```

v3.4-rc6-6-g2fff27512600

Are you sure we wanna tag so solid and time proven commit as Fixes: :)
?

> 
> > ---
> >  drivers/ata/pata_ep93xx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> > index c6e043e05d43..4ce0f37c7a89 100644
> > --- a/drivers/ata/pata_ep93xx.c
> > +++ b/drivers/ata/pata_ep93xx.c
> > @@ -939,7 +939,7 @@ static int ep93xx_pata_probe(struct
> > platform_device *pdev)
> >  
> >         drv_data = devm_kzalloc(&pdev->dev, sizeof(*drv_data),
> > GFP_KERNEL);
> >         if (!drv_data) {
> > -               err = -ENXIO;
> > +               err = -ENOMEM;
> >                 goto err_rel_gpio;
> >         }
> >  
> > @@ -952,7 +952,7 @@ static int ep93xx_pata_probe(struct
> > platform_device *pdev)
> >         /* allocate host */
> >         host = ata_host_alloc(&pdev->dev, 1);
> >         if (!host) {
> > -               err = -ENXIO;
> > +               err = -ENOMEM;
> >                 goto err_rel_dma;
> >         }
> >  
> > 
> 





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux