On 8/22/23 10:10 PM, Sergei Shtylyov wrote: [...] >> thanks for reviewing - this has mostly been addressed in v2 or v3 (which I forgot to send to you, sorry). Damien asked for the patch title to be changed (now 'ata: pata_falcon: add data_swab option to byte-swap disk data) so you might have missed it on the list. > > I didn't want to repeat such request after him. :-) > I'm subscribed to linux-ide thru my Gmail account, and I'm still not seeing > your further patch versions on the list... :-/ Had to reply from Gmail account as the OMP server rejected my msg. Please be sure to always CC: me on the PATA patches! > [...] > >>>> Some users of pata_falcon on Q40 have IDE disks in default >>>> IDE little endian byte order, whereas legacy disks use >>>> host-native big-endian byte order as on the Atari Falcon. >>>> >>>> Add module parameter 'data_swab' to allow connecting drives >>>> with non-native data byte order. Drives selected by the >>>> data_swap bit mask will have their user data byte-swapped to >>>> host byte order, i.e. 'pata_falcon.data_swab=2' will byte-swap >>>> all user data on drive B, leaving data on drive A in native >>>> byte order. On Q40, drives on a second IDE interface may be >>>> added to the bit mask as bits 2 and 3. >>>> >>>> Default setting is no byte swapping, i.e. compatibility with >>>> the native Falcon or Q40 operating system disk format. >>>> >>>> Cc: William R Sowerbutts <will@xxxxxxxxxxxxxx> >>>> Cc: Finn Thain <fthain@xxxxxxxxxxxxxx> >>>> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >>>> Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx> [...] MBR, Sergey