On 7/31/23 18:16, Uwe Kleine-König wrote: > Hello, > > this series adapts the platform drivers below drivers/ata to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warning. The > device is removed anyhow and an early return from .remove() usually yields a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > All drivers touched here returned zero unconditionally in their remove > callback, so they could all be converted trivially to .remove_new(). > > Once all drivers are converted to .remove_new(), .remove() will be changed to > match today's .remove_new(). Then the drivers here will be converted back > trivially using s/remove_new/remove/. Given the amount of platform drivers this > is still a bit in the future, though. Applied to for-6.6 with minor tweaks to the patch titles prefix. Thanks ! -- Damien Le Moal Western Digital Research
