On 31-07-23, 11:16, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/ata/pata_arasan_cf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322e79..e11eea2e749a 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -916,15 +916,13 @@ static int arasan_cf_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int arasan_cf_remove(struct platform_device *pdev)
> +static void arasan_cf_remove(struct platform_device *pdev)
> {
> struct ata_host *host = platform_get_drvdata(pdev);
> struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>
> ata_host_detach(host);
> cf_exit(acdev);
> -
> - return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> @@ -965,7 +963,7 @@ MODULE_DEVICE_TABLE(of, arasan_cf_id_table);
>
> static struct platform_driver arasan_cf_driver = {
> .probe = arasan_cf_probe,
> - .remove = arasan_cf_remove,
> + .remove_new = arasan_cf_remove,
> .driver = {
> .name = DRIVER_NAME,
> .pm = &arasan_cf_pm_ops,
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh
