On 7/25/23 6:19 PM, Sergey Shtylyov wrote: [...] >> The 'rv' will be set to 0 after calling of_property_read_reg(), >> return correct error code in the error path. > > Thanks for catching this! > It also means tht the initializer for 'tv' is pointless. Sorry, 'rv'. :-) > A material for a clenup, I think... Might as well do it here... Damian? >> Fixes: d0b2461678b1 ("ata: Use of_property_read_reg() to parse "reg"") >> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > [...] MBR, Sergey