Re: [PATCH] ata: pata_octeon_cf: fix error return code in octeon_cf_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/25/23 6:19 PM, Sergey Shtylyov wrote:
[...]

>> The 'rv' will be set to 0 after calling of_property_read_reg(),
>> return correct error code in the error path.
> 
>    Thanks for catching this!
>    It also means tht the initializer for 'tv' is pointless.

   Sorry, 'rv'. :-)

> A material for a clenup, I think...

   Might as well do it here... Damian?

>> Fixes: d0b2461678b1 ("ata: Use of_property_read_reg() to parse "reg"")
>> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> 
> [...]

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux