On 6/22/23 22:41, Rob Herring wrote: > On Wed, Jun 21, 2023 at 10:26 PM Damien Le Moal <dlemoal@xxxxxxxxxx> wrote: >> >> On 6/22/23 12:01, Guenter Roeck wrote: >>> On 6/21/23 17:57, Damien Le Moal wrote: >>>> On 6/22/23 01:51, Guenter Roeck wrote: >>>>> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >>>>>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >>>>>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >>>>>> so other arches can't be enabled. >>>>>> >>>>>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> >>>>>> --- >>>>>> Tested on allmodconfig build. Not sure if there's other MIPS configs >>>>>> where this doesn't work. We'll see what 0-day says. >>>>> >>>>> Odd, in next-20230621 I get: >>>>> >>>>> Building mips:allmodconfig ... failed >>>> >>>> Indeed odd. Given that this is an allmodconfig, I would assume that >>>> CONFIG_CAVIUM_OCTEON_SOC is set ? >>>> >>> >>> No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, >>> meaning only one of the choices can be set, and mips:allmodconfig >>> selects a different choice. >> >> OK. Then I think I need to drop this patch as I do not see how to allow >> COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set. >> >> Rob ? > > These could be fixed, but not sure it's worth the effort. Agreed. And given that we are at rc7 already, this effort should not be now anyway. I will drop this patch. -- Damien Le Moal Western Digital Research
