Re: [PATCH 0/6] libata: remove references to 'old' error handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 22, 2023 at 08:46:18AM +0200, Hannes Reinecke wrote:
> On 5/22/23 02:46, Damien Le Moal wrote:
> > On 5/11/23 07:52, Hannes Reinecke wrote:
> > > Hi all,
> > > 
> > > now that the ipr driver has been modified to not hook into libata
> > > all drivers now use the 'new' error handler, so we can remove any
> > > references to it. And do a general cleanup to remove callbacks
> > > which are no longer needed.
> > 
> > Hannes,
> > 
> > Are you sending a v2 to address the comments ?
> > 
> Sure. Just catching up wfter yet another week of conference.

Hello Hannes,

Are you planning on sending a V2?

It would be nice for the series to cook in linux-next for the customary
2+ weeks before being sent to Linus, especially considering the kernel
test robot regression report.

I assume that the regression report is related to the review comment
that I gave, i.e. that ata_dump_status() is now called unconditionally:

         %stddev     %change         %stddev
pp.vprintk_emit._printk.ata_dump_status.ata_scsi_qc_complete.ata_qc_complete_multiple
      0.00           +22.4       22.41 ±  8%  perf-profile.calltrace.cycles-


Kind regards,
Niklas




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux