Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
Date: Mon, 5 Jun 2023 12:45:54 +0300
Cc: John Garry <john.g.garry@xxxxxxxxxx>, Jason Yan <yanaijie@xxxxxxxxxx>
In-reply-to: <20230605013212.573489-3-dlemoal@kernel.org>
References: <20230605013212.573489-1-dlemoal@kernel.org> <20230605013212.573489-3-dlemoal@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 6/5/23 4:32 AM, Damien Le Moal wrote:

> Instead of hardconfign the device flag tests to detect if NCQ is

   Hardcoding?

> supported and enabled in ata_eh_speed_down(), use ata_ncq_enabled().
> 
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
[...]

MBR, Sergey

Follow-Ups:
- Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
  - From: Damien Le Moal

References:
- [PATCH 0/3] Cleanups and improvements
  - From: Damien Le Moal
- [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
  - From: Damien Le Moal

Prev by Date: Re: [PATCH 3/3] ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()
Next by Date: Re: [PATCH 3/3] ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()
Previous by thread: Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
Next by thread: Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]