On 5/23/23 17:29, John Garry wrote: [...] >> + * or 2 (IDE master + slave). However, the former case includes >> + * libsas hosted devices which are numbered per host, leading >> + * to devno potentially being larger than 0 but with each ata device >> + * having its own ata port and ata link. To accommodate these, ignore >> + * devno and always use device number 0. >> + */ >> + if (likely(!sata_pmp_attached(ap))) { > > Is this function ever used in fastpath? I doubt it, but I suppose having > likely() can't do any damage. Yes, we could drop that. -- Damien Le Moal Western Digital Research