Hi Christoph, On Sun, Apr 16, 2023 at 8:20 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Fri, Apr 14, 2023 at 03:55:07PM +0200, Johannes Berg wrote: > > On Sun, 2023-04-09 at 18:13 -0700, Randy Dunlap wrote: > > > Current build of pata_cs5536 for i386 UML fails with: > > > > > > ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > > > ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > > > ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > > ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > > > > > Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. > > > > > > > Hm. Does this make sense? I can't see it'd work on UML to configure an > > IDE device through MSRs? Surely that can't work? IOW, that entire driver > > can't really work anyway can it? > > > > OTOH, maybe theoretically it could work in PCI, just not with MSRs, and > > then this patch makes some sense? > > I think it is is integrated into actual Geode SOCs. That being > said something like the patch below seems as simple as it gets and > at least gives build coverage on uml CS5536 is the Geode Companion Device, i.e. the South Bridge, which can be used with other devices, AFAIK. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds