Hello Bart, On Thu, Mar 16, 2023 at 11:41:21AM -0700, Bart Van Assche wrote: > On 3/15/23 19:00, Damien Le Moal wrote: > > Bart, > > > > I would like to hear your opinion as well. > > Isn't sending a ping after only three days a bit soon for such a large > patch? While I was never really any good at math, I'm quite sure that 16-9=7 :) Which is the recommended (minimum) time to wait before you ping someone: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#don-t-get-discouraged-or-impatient > > Regarding your question: I like the block/ioprio.c changes in this version > of this patch series much better than the changes in the previous version of > this patch series. > > No objections from my side about the changes in this patch (02/19). You are one of the main people who didn't fancy the old user facing API. I think that you (and Martin) gave some really good points, we listened and came up with a new user facing API. When you have the time, we would be very grateful if you could provide a more thorough review, i.e. provide a R-b tag or give some feedback. Your help is appreciated! Kind regards, Niklas
