Hi Krzysztof,
On 2023/02/13 18:10, Krzysztof Kozlowski wrote:
On 13/02/2023 05:54, Kunihiko Hayashi wrote:
Add UniPhier SATA controller compatible string to the platform binding.
This controller needs maximum three reset controls.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
---
.../devicetree/bindings/ata/ahci-platform.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
Changes since v1:
- Restrict resets property changes with compatible strings
- Fix maxItems from two to three
diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
index 7dc2a2e8f598..25dd5ffaa517 100644
--- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
+++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
@@ -45,6 +45,9 @@ properties:
- marvell,armada-8k-ahci
- marvell,berlin2-ahci
- marvell,berlin2q-ahci
+ - socionext,uniphier-pro4-ahci
+ - socionext,uniphier-pxs2-ahci
+ - socionext,uniphier-pxs3-ahci
- const: generic-ahci
- enum:
Top level is saying reset=1, so did you test your bindings?
Umm, I didn't see any errors on dt_binding_check, anyway I'll add
initial minItems:1 and maxItems:3 on top level first.
- cavium,octeon-7130-ahci
@@ -76,6 +79,20 @@ properties:
resets:
maxItems: 1
+if:
Keep it in allOf like in example-schema. Will save you one re-indent
pretty soon...
I see. I'll move if clause into allOf, and also move the original allOf.
+ properties:
+ compatible:
+ contains:
+ enum:
+ - socionext,uniphier-pro4-ahci
+ - socionext,uniphier-pxs2-ahci
+ - socionext,uniphier-pxs3-ahci
+then:
+ properties:
+ resets:
+ minItems: 1
+ maxItems: 3
And entire allOf goes to the place like in example-schema.
I've got it. and I'll fix it (minItems:2).
Thank you,
---
Best Regards
Kunihiko Hayashi
