On 1/31/23 00:25, Jens Axboe wrote: > On 1/30/23 12:10 AM, Damien Le Moal wrote: >> On 1/30/23 15:48, Christoph Hellwig wrote: >>> On Sun, Jan 29, 2023 at 08:44:06PM -0700, Jens Axboe wrote: >>>> I would prefer if we just delete it after merging this one, in the same >>>> release. I don't think there's any point in delaying, as we're not >>>> removing any functionality. >>>> >>>> You could just queue that up too when adding this patch. >>> >>> I'd prefer to just deprecate. But most importantly I want this patch >>> in ASAP in some form. >> >> I will queue it. But I think it needs a follow up to result in something >> consistent with KConfig. So either deprecate or delete PARPORT. I can queue the >> deprecate patch and delete in 6.4, even though I share Jen's opinion to simply >> delete directly. I am still fine either way. >> >> Jens, >> >> If you are OK with that, can I get your ack for the deprecate patch ? Unless you >> prefer taking it through the block tree. Either way is fine with me. > > Yeah I'd be happy to ack that, did you post it? You can add my ack to the > new driver, fine with that now. Will do. But I did not want to queue the new driver without killing (or deprecating) the old code too. Ondrej has now sent 2 patches to remove the old code. Please ack that ! -- Damien Le Moal Western Digital Research