On Tue, Jan 17, 2023 at 04:15:01PM +0900, Damien Le Moal wrote: > Trying to get to a pretty solution keeping a single line for setting sense > + status. But sure, splitting out the status setting works too. I suggested just adding a wrapper above. And while I tried to white board code it here in the mail I think we can do even better than that, and just drop this change and just open code the call to scsi_build_sense_buffer for the CDL use case. While we're at it: That !cmd check in ata_scsi_set_sense looks really odd, can someone clean that up and just remove the calls where there is no command?
