> extern int scsi_mode_sense(struct scsi_device *sdev, int dbd, int modepage, > - unsigned char *buffer, int len, int timeout, > - int retries, struct scsi_mode_data *data, > + int subpage, unsigned char *buffer, int len, > + int timeout, int retries, > + struct scsi_mode_data *data, Please drop the extern while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
