Re: [PATCH v2 02/18] ata: libata: allow ata_eh_request_sense() to not set CHECK_CONDITION

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Niklas Cassel <niklas.cassel@xxxxxxx>
Subject: Re: [PATCH v2 02/18] ata: libata: allow ata_eh_request_sense() to not set CHECK_CONDITION
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 16 Jan 2023 22:08:20 -0800
Cc: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20230112140412.667308-3-niklas.cassel@wdc.com>
References: <20230112140412.667308-1-niklas.cassel@wdc.com> <20230112140412.667308-3-niklas.cassel@wdc.com>

Similar comment here - just move setting the SAM_STAT_CHECK_CONDITION
out of this function and into the caller.  It'll need a bool return for
that, though.

References:
- [PATCH v2 00/18] Add Command Duration Limits support
  - From: Niklas Cassel
- [PATCH v2 02/18] ata: libata: allow ata_eh_request_sense() to not set CHECK_CONDITION
  - From: Niklas Cassel

Prev by Date: Re: [PATCH v2 01/18] ata: libata: allow ata_scsi_set_sense() to not set CHECK_CONDITION
Next by Date: Re: [PATCH v2 04/18] scsi: rename and move get_scsi_ml_byte()
Previous by thread: Re: [PATCH v2 02/18] ata: libata: allow ata_eh_request_sense() to not set CHECK_CONDITION
Next by thread: [PATCH v2 03/18] scsi: core: allow libata to complete successful commands via EH
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]

Powered by Linux