Hi-- On 1/12/23 20:37, Peter Foley wrote: > This driver uses MSR functions that aren't implemented under UML. > Avoid building it to prevent tripping up allyesconfig. > > e.g. > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3a3): undefined reference to `__tracepoint_read_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x3d2): undefined reference to `__tracepoint_write_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x457): undefined reference to `__tracepoint_write_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x481): undefined reference to `do_trace_write_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4d5): undefined reference to `do_trace_write_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x4f5): undefined reference to `do_trace_read_msr' > /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: pata_cs5535.c:(.text+0x51c): undefined reference to `do_trace_write_msr' > > Signed-off-by: Peter Foley <pefoley2@xxxxxxxxxxx> I have a similar patch on my system that I have never sent. I think that PATA_CS5536 needs the same treatment. Anyway: Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/ata/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index eceaec33af65..9695c4404e26 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -640,6 +640,7 @@ config PATA_CS5530 > config PATA_CS5535 > tristate "CS5535 PATA support (Experimental)" > depends on PCI && (X86_32 || (X86_64 && COMPILE_TEST)) > + depends on !UML > help > This option enables support for the NatSemi/AMD CS5535 > companion chip used with the Geode processor family. > > --- > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 > change-id: 20230112-umide-18c116111232 > > Best regards, -- ~Randy
