Re: [PATCH v9 1/6] block: add a sanity check for non-write flush/fua bios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/11/23 13:32, Jens Axboe wrote:
> On Jan 10, 2023, at 2:58 PM, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> On 1/10/23 22:27, Damien Le Moal wrote:
>>> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>>>
>>> Check that the PREFUSH and FUA flags are only set on write bios,
>>> given that the flush state machine expects that.
>>>
>>> [Damien] The check is also extended to REQ_OP_ZONE_APPEND operations as
>>> these are data write operations used by btrfs and zonefs and may also
>>> have the REQ_FUA bit set.
>>>
>>> Reported-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
>>> Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>
>>
>> Christoph, Jens,
>>
>> Are you OK with this patch ?
> 
> I already acked a previous version, you just didn’t pick it up. 

I noticed your ack. But since I changed the patch, I wanted confirmation
again. Do you want me to pickup this version through the ATA tree ?
You can take it through the block tree as the block patch can go in
separately. There are no conflicts/dependencies for compile with the ATA
part. Whichever is fine with me.

> 
>
> Jens Axboe
> 

-- 
Damien Le Moal
Western Digital Research





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux