On 1/7/23 03:03, Tejun Heo wrote: >> We can take a big hammer here and start with enabling only ACS-5 and >> above for now. That will represent the set of devices that are in >> development right now, and only a few already released (I have some in >> my test boxes and they are not even a few months old...). > > All that said, yeah, if we restrict it to only the newest devices, they're > more likely to be well behaved and a lot more visible when they misbehave. > That sounds reasonable to me. I re-posted the series without patch 7 enabling FUA by default. This maintains the current state of libata while still cleaning up nicely all the code around FUA. I will send 1 or 2 patches later after thinking a little more about how to safely enable FUA by default only for recent drives or drives of interest. E.g. SMR drives as the lack of FUA support for them forces the use of the block layer flush machinery, which itself causes write reordering... That needs to be addressed too, and will look at that. Thanks for the feedback. -- Damien Le Moal Western Digital Research
