Hello!
On 10/29/22 12:07 AM, Sergey Shtylyov wrote:
> Clang gives a warning when compiling pata_legacy.c with 'make W=1' about
> the 'rt' local variable in pdc20230_set_piomode() being set but unused.
> Quite obviously, there is an outb() call missing to write back the updated
> variable. Moreover, checking the docs by Petr Soucek revealed that bitwise
> AND should have been done with a negated timing mask and the master/slave
> timing masks were swapped while updating...
>
> Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers.")
> Reported-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> ---
Forgot to mention that the patch was done against the 'master' branch
of libata.git...
[...]
MBR, Sergey
