On 10/25/22 03:48, Maciej S. Szmigiero wrote: > On 24.10.2022 09:26, Damien Le Moal wrote: >> These patches cleanup and improve libata support for the FUA device >> feature. Patch 3 enables FUA support by default for any drive that >> reports supporting the feature. >> >> Changes from v1: >> - Removed Maciej's patch 2. Instead, blacklist drives which are known >> to have a buggy FUA support. >> >> Damien Le Moal (3): >> ata: libata: cleanup fua handling >> ata: libata: blacklist FUA support for known buggy drives >> ata: libata: Enable fua support by default >> > > Thanks for the updated series. > > In general (besides the small commit message thing that Sergey had > already mentioned) it looks good to me, so: > Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@xxxxxxxxxx> Thanks. I need to do some more testing using some very old drives I found. So far, no issues: detection works, some drives have FUA, other not. For the ones that have FUA, I am running fstests (ext4 and xfs) to check for weird behavior with REQ_FUA writes. Once I complete all tests I will queue this. > > Thanks, > Maciej > -- Damien Le Moal Western Digital Research
