On 10/24/22 19:16, Sergey Shtylyov wrote: > Hello! > > On 10/24/22 10:26 AM, Damien Le Moal wrote: > >> Change the default value of the fua module parameter to 1 to enable fua >> support by default for all devices supporting it. This parameter >> description is also updated to indicate it is deprecated and that >> libata.force=[no]fua should be used to control fua support. > > Mhm, where is that change? You only seem to change the default... Oops. Forgot to update the commit message. I thought there was a way to mark a module argument as deprecated, but there is not. Need to simplify this commit message. > >> >> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Hannes Reinecke <hare@xxxxxxx> >> --- >> drivers/ata/libata-core.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c >> index 27aec8e63a8c..867e2c423627 100644 >> --- a/drivers/ata/libata-core.c >> +++ b/drivers/ata/libata-core.c >> @@ -127,9 +127,9 @@ int atapi_passthru16 = 1; >> module_param(atapi_passthru16, int, 0444); >> MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])"); >> >> -int libata_fua = 0; >> +int libata_fua = 1; >> module_param_named(fua, libata_fua, int, 0444); >> -MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)"); >> +MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])"); >> >> static int ata_ignore_hpa; >> module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > > MBR, Sergey -- Damien Le Moal Western Digital Research
