On 10/19/22 04:10, Niklas Cassel wrote:
> Not only is this function unused, but even worse, the bit it is checking
> is actually used for signaling if the feature is supported, not enabled.
> Therefore, remove the unused helper function ata_id_lba48_enabled().
>
> ata_id_has_lba48() is left unmodified, since this extra supported bit
> (Bit 10 of word 86) is simply a copy of the bit that ata_id_has_lba48()
> already checks (Bit 10 of word 83), see ACS-5 r10:
> 7.13.6.41 Words 85..87, 120: Commands and feature sets supported or enabled
>
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
Applied with patches 2 and 3 to for-6.2. Thanks !
> ---
> include/linux/ata.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index e3050e153a71..c04aca58448a 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -698,15 +698,6 @@ static inline bool ata_id_has_lba48(const u16 *id)
> return id[ATA_ID_COMMAND_SET_2] & (1 << 10);
> }
>
> -static inline bool ata_id_lba48_enabled(const u16 *id)
> -{
> - if (ata_id_has_lba48(id) == 0)
> - return false;
> - if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
> - return false;
> - return id[ATA_ID_CFS_ENABLE_2] & (1 << 10);
> -}
> -
> static inline bool ata_id_hpa_enabled(const u16 *id)
> {
> /* Yes children, word 83 valid bits cover word 82 data */
--
Damien Le Moal
Western Digital Research
