On 10/13/22 14:55, Alexander Stein wrote: > Hello Damien, > > Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal: >> On 10/12/22 22:30, Alexander Stein wrote: >>> Hello Fabio, >>> >>> Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam: >>>> Hi Alexander, >>>> >>>> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein >>>> >>>> <alexander.stein@xxxxxxxxxxxxxxx> wrote: >>>>> 'ahci:' is an invalid prefix, preventing the module from autoloading. >>>>> Fix this by using the 'platform:' prefix and DRV_NAME. >>>> >>>> What about adding a Fixes tag? >>>> >>>> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx> >>> >>> Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at >>> which point auto loading stopped working (if it did at all). >> >> Given that the alias was wrong in the first place when added for a >> platform driver, this I think should be a fix for: >> >> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms") > > I was hesitating tagging the very first commit, not knowing if it did work at > that time. But it seems reasonable. Yep, I do not think this will hurt... If someone think I am wrong, please scream ! > >> I can add the Fixes tag when applying. > > Thanks! > > Best regards, > Alexander > > -- Damien Le Moal Western Digital Research