On Sun, Sep 04, 2022 at 08:34:20AM +0800, kernel test robot wrote: > Hi Serge, > > I love your patch! Yet something to improve: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on axboe-block/for-next linus/master v6.0-rc3 next-20220901] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220823-024133 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220904/202209040834.w5y0s1NR-lkp@xxxxxxxxx/config) > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/e628913a210e29775bc995d1ed3ed58ab13416b8 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220823-024133 > git checkout e628913a210e29775bc995d1ed3ed58ab13416b8 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/ata/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > In file included from include/linux/clk.h:13, > from drivers/ata/ahci_dwc.c:11: > >> drivers/ata/ahci_dwc.c:372:50: error: 'ahci_dwc_suspend' undeclared here (not in a function); did you mean 'ahci_dwc_probe'? > 372 | static DEFINE_SIMPLE_DEV_PM_OPS(ahci_dwc_pm_ops, ahci_dwc_suspend, > | ^~~~~~~~~~~~~~~~ > include/linux/kernel.h:57:44: note: in definition of macro 'PTR_IF' > 57 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) > | ^~~ > include/linux/pm.h:313:20: note: in expansion of macro 'pm_sleep_ptr' > 313 | .suspend = pm_sleep_ptr(suspend_fn), \ > | ^~~~~~~~~~~~ > include/linux/pm.h:373:9: note: in expansion of macro 'SYSTEM_SLEEP_PM_OPS' > 373 | SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ > | ^~~~~~~~~~~~~~~~~~~ > include/linux/pm.h:399:9: note: in expansion of macro '_DEFINE_DEV_PM_OPS' > 399 | _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL, NULL) > | ^~~~~~~~~~~~~~~~~~ > drivers/ata/ahci_dwc.c:372:8: note: in expansion of macro 'DEFINE_SIMPLE_DEV_PM_OPS' > 372 | static DEFINE_SIMPLE_DEV_PM_OPS(ahci_dwc_pm_ops, ahci_dwc_suspend, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/ata/ahci_dwc.c:373:33: error: 'ahci_dwc_resume' undeclared here (not in a function); did you mean 'ahci_port_resume'? > 373 | ahci_dwc_resume); > | ^~~~~~~~~~~~~~~ > include/linux/kernel.h:57:44: note: in definition of macro 'PTR_IF' > 57 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) > | ^~~ > include/linux/pm.h:314:19: note: in expansion of macro 'pm_sleep_ptr' > 314 | .resume = pm_sleep_ptr(resume_fn), \ > | ^~~~~~~~~~~~ > include/linux/pm.h:373:9: note: in expansion of macro 'SYSTEM_SLEEP_PM_OPS' > 373 | SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ > | ^~~~~~~~~~~~~~~~~~~ > include/linux/pm.h:399:9: note: in expansion of macro '_DEFINE_DEV_PM_OPS' > 399 | _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL, NULL) > | ^~~~~~~~~~~~~~~~~~ > drivers/ata/ahci_dwc.c:372:8: note: in expansion of macro 'DEFINE_SIMPLE_DEV_PM_OPS' > 372 | static DEFINE_SIMPLE_DEV_PM_OPS(ahci_dwc_pm_ops, ahci_dwc_suspend, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/ata/ahci_dwc.c:267:12: warning: 'ahci_dwc_reinit_host' defined but not used [-Wunused-function] > 267 | static int ahci_dwc_reinit_host(struct ahci_host_priv *hpriv) > | ^~~~~~~~~~~~~~~~~~~~ Right. The SYSTEM_SLEEP_PM_OPS macro doesn't imply ifdef'ing the sleep action-methods. I'll drop the conditional compilation then. -Sergey > > > vim +372 drivers/ata/ahci_dwc.c > > 371 > > 372 static DEFINE_SIMPLE_DEV_PM_OPS(ahci_dwc_pm_ops, ahci_dwc_suspend, > > 373 ahci_dwc_resume); > 374 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp
