On 2022/08/04 7:35, Tomas Henzl wrote:
> Print the timeout value may help in troubleshooting failures.
s/Print/Printing
>
> Signed-off-by: David Milburn <dmilburn@xxxxxxxxxx>
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
You forgot to fix the patch title prefix. Please change it to "ata: libata-core:".
> ---
> V3: rewording subject and description, no functional change
> V2: timeout changed to unsigned int as in for-next
>
> drivers/ata/libata-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 826d41f341e4..0fc4782ef4f8 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -1578,8 +1578,8 @@ static unsigned ata_exec_internal_sg(struct ata_device *dev,
> else
> ata_qc_complete(qc);
>
> - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
> - command);
> + ata_dev_warn(dev, "qc timeout after %u msecs (cmd 0x%x)\n",
> + timeout, command);
Please keep the argument indentation to align with "(".
> }
>
> spin_unlock_irqrestore(ap->lock, flags);
>
--
Damien Le Moal
Western Digital Research
