Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.19-rc8 next-20220728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ata-libata-scsi-Refactor-scsi_6_lba_len-with-use-of-get_unaligned_be24/20220726-234746 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e0dccc3b76fb35bb257b4118367a883073d7390e config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220729/202207291100.qslmQQl1-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/ae9a00d0e0375aa2aea7a61dc2894d9d06005f8e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/ata-libata-scsi-Refactor-scsi_6_lba_len-with-use-of-get_unaligned_be24/20220726-234746 git checkout ae9a00d0e0375aa2aea7a61dc2894d9d06005f8e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ata/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/ata/libata-scsi.c: In function 'scsi_6_lba_len': >> drivers/ata/libata-scsi.c:1320:39: warning: passing argument 1 of 'get_unaligned_be24' makes pointer from integer without a cast [-Wint-conversion] 1320 | *plba = get_unaligned_be24(cdb[1]) & 0x1fffff; | ~~~^~~ | | | u8 {aka unsigned char} In file included from ./arch/x86/include/generated/asm/unaligned.h:1, from drivers/ata/libata-scsi.c:33: include/asm-generic/unaligned.h:90:50: note: expected 'const void *' but argument is of type 'u8' {aka 'unsigned char'} 90 | static inline u32 get_unaligned_be24(const void *p) | ~~~~~~~~~~~~^ vim +/get_unaligned_be24 +1320 drivers/ata/libata-scsi.c 1307 1308 /** 1309 * scsi_6_lba_len - Get LBA and transfer length 1310 * @cdb: SCSI command to translate 1311 * 1312 * Calculate LBA and transfer length for 6-byte commands. 1313 * 1314 * RETURNS: 1315 * @plba: the LBA 1316 * @plen: the transfer length 1317 */ 1318 static void scsi_6_lba_len(const u8 *cdb, u64 *plba, u32 *plen) 1319 { > 1320 *plba = get_unaligned_be24(cdb[1]) & 0x1fffff; 1321 *plen = cdb[4]; 1322 } 1323 -- 0-DAY CI Kernel Test Service https://01.org/lkp
