On 7/19/22 20:42, Xin Gao wrote: > do not initialise statics to 0 > > Signed-off-by: Xin Gao <gaoxin@xxxxxxxxxx> > --- > drivers/ata/libata-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 40e816419f48..bbb98433d160 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -119,7 +119,7 @@ static int atapi_enabled = 1; > module_param(atapi_enabled, int, 0444); > MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on [default])"); > > -static int atapi_dmadir = 0; > +static int atapi_dmadir; > module_param(atapi_dmadir, int, 0444); > MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off [default], 1=on)"); > Is this solving any static analyzer or compiler warning ? If not, this is not a very useful change. -- Damien Le Moal Western Digital Research
