Re: [PATCH v3 04/10] ata: ahci: Use `pm_suspend_preferred_s2idle`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/1/22 00:06, Damien Le Moal wrote:
On 7/1/22 11:33, Mario Limonciello wrote:
Drop the direct check from the FADT and use the helper instead.

Where is this helper defined ? Seeing that this is patch 4/10, I have no
context for this patch. Please send the whole series next time.


My apologies; I should have also included you at least on 1/10, but was trying to save your inbox for the other 8 patches that were not relevant to you.

The whole series is on LKML here:
https://lore.kernel.org/lkml/20220701023328.2783-1-mario.limonciello@xxxxxxx/

If there's a v4 I'll include you on 1/10 (unless you also want to be on the others too).


Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
  drivers/ata/ahci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index c1eca72b4575..3f79b732dd00 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1611,7 +1611,7 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap,
#ifdef CONFIG_ACPI
  	if (policy > ATA_LPM_MED_POWER &&
-	    (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)) {
+	    pm_suspend_preferred_s2idle()) {
  		if (hpriv->cap & HOST_CAP_PART)
  			policy = ATA_LPM_MIN_POWER_WITH_PARTIAL;
  		else if (hpriv->cap & HOST_CAP_SSC)






[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux