On 6/29/22 22:32, Sergey Shtylyov wrote: > On 6/29/22 4:51 AM, Damien Le Moal wrote: > >>> x86_64 allmodconfig build with W=1 gives these warnings: >>> >>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’: >>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable] >>> u32 reg, dummy; >>> ^~~~~ >>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’: >>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable] >>> u32 reg, dummy; >>> ^~~~~ >>> cc1: all warnings being treated as errors >>> >>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is >>> stubbed, which is the same as what we already do in pata_cs5536.c . >>> >>> Signed-off-by: John Garry <john.garry@xxxxxxxxxx> >> >> Applied to for-5.20. Thanks ! > > Why not to 5.19? The warnings are fatal as can be seen from the commit log... This is only a compile warning and nobody complained, not even the 0-day bot/linux-next builds, and for years... Most definitely not an urgent fix. But yeah, sure, can do 5.19 fixes too. > > MBR, Sergey > -- Damien Le Moal Western Digital Research
