On 6/22/22 05:52, Brian King wrote: > On 6/21/22 3:36 PM, Brian King wrote: >> On 6/19/22 11:48 PM, Damien Le Moal wrote: >>> >>> Polling people here: Do we still need the scsi IPR driver for IBM Power >>> Linux RAID adapters (IBM iSeries: 5702, 5703, 2780, 5709, 570A, 570B >>> adapters) ? >>> >>> The reason I am asking is because this driver is the *only* libsas/ata >>> driver that does not define a ->error_handler port operation. If this >>> driver is removed, or if it is modified to use a ->error_handler operation >>> to handle failed commands, then a lot of code simplification can be done >>> in libata, which I am trying to do to facilitate the processing of some >>> special error completion for commands using a command duration limit. >> >> We still need it around for now. IBM still sells these adapters >> and they can still be ordered even on our latest Power 10 systems. > > At one point I did look into modifying ipr to use an ->error_handler. > I recall I ran into some issues that resulted in this getting put > on the shelf, but its been a while. I'll go dig that code up and > see what it looks like. Thanks. It would be really great if you can convert to using error_handler. This is really the last ata/libsas driver that does not use this. > > Thanks, > > Brian > > -- Damien Le Moal Western Digital Research
