On 6/18/22 03:16, Sergey Shtylyov wrote: > On 6/16/22 11:51 PM, Sergey Shtylyov wrote: > >> ata_eh_nr_in_flight() counts the # of the active tagged commands and thus >> cannot return a negative value but the result type is nevertheless *int*; >> switching it to *unsigned int* (along with the local variables receiving >> the function's result) helps avoiding the sign extension instructions when >> comparing with or assigning to *unsigned long *ata_port::fastdrain_cnt and > > Grr, a typo! Should have been *unsigned long* ata_port::fastdrain_cnt... > Damien, coyld you please fix it? OK. Note: please stop using markdown stuff like *xxx*. That is not useful and that will avoid this kind of typos. > >> thus results in a more compact 64-bit code... >> >> Found by Linux Verification Center (linuxtesting.org) with the SVACE static >> analysis tool. >> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > [...] > > MBR, Sergey -- Damien Le Moal Western Digital Research
