On 6/17/22 12:00, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Looks good. But please do not randomly add tags like the above ack. I
never sent that ! And since I will be applying this patch, I will add my
signed-of-by tag, not a acked-by tag.
> Signed-off-by: Edward Wu <edwardwu@xxxxxxxxxxx>
> ---
> Thanks for your kindly guiding.
>
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
Damien Le Moal
Western Digital Research
