On 6/14/22 8:24 AM, Damien Le Moal wrote: [...] >> Make the 'timeout' parameter to ata_exec_internal_sg() *unsigned int* as >> msecs_to_jiffies() that it calls takes just *unsigned int* for the time in >> milliseconds. Then follow the suit with ata_exec_internal(), its only >> caller; also fix up ata_dev_set_feature(), the only ata_exec_internal()'s >> caller that explicitly passes *unsigned long* variable for timeout... >> >> Found by Linux Verification Center (linuxtesting.org) with the SVACE static >> analysis tool. > > Since you are changing this function signature, can you also make it > static since it is only used in libata-core.c ? The declaration in > drivers/ata/libata.h is useless. Hopefully you don't mean I should do it in the same patch? :-) [...] MBR, Sergey
