On Thu, May 12, 2022 at 08:57:55AM +0200, Hannes Reinecke wrote: > On 5/12/22 01:18, Serge Semin wrote: > > Currently not all of the Port-specific capabilities listed in the > > PORT_CMD-enumeration. Let's extend that set with the Cold Presence > > Detection and Mechanical Presence Switch attached to the Port flags [1] so > > to closeup the set of the platform-specific port-capabilities flags. Note > > these flags are supposed to be set by the platform firmware if there is > > one. Alternatively as we are about to do they can be set by means of the > > OF properties. > > > > While at it replace PORT_IRQ_DEV_ILCK with PORT_IRQ_DEV_MPS and fix the > > comment there. In accordance with [2] that IRQ flag is supposed to > > indicate the state of the signal coming from the Mechanical Presence > > Switch. > > > > [1] Serial ATA AHCI 1.3.1 Specification, p.27 > > [2] Serial ATA AHCI 1.3.1 Specification, p.7 > > > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/ata/ahci.h | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > You might want to adapt the subject line, as this patch doesn't touch > libahci at all. AFAICS ahci.h is mainly (if not to say only) the header file of the libahci.c module interface. Modifying ahci.h I basically update the libahci interface. So based on that the subject is fully correct. > Other than that: > > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Thanks. -Sergey > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Kernel Storage Architect > hare@xxxxxxx +49 911 74053 688 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg > HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
