Re: [PATCH v1 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal

Re: [PATCH v1 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq()

Date Prev

Date Next

Thread Prev

Date Index

Thread Index

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Subject: Re: [PATCH v1 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq()

From: Wolfram Sang <wsa@xxxxxxxxxx>

Date: Wed, 4 May 2022 22:09:43 +0200

Cc: Sergey Shtylyov <s.shtylyov@xxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Anatolij Gustschin <agust@xxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Pantelis Antoniou <pantelis.antoniou@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>

In-reply-to: <20220504134449.64473-1-andriy.shevchenko@linux.intel.com>

Mail-followup-to: Wolfram Sang <wsa@xxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Sergey Shtylyov <s.shtylyov@xxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Anatolij Gustschin <agust@xxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Pantelis Antoniou <pantelis.antoniou@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>

References: <20220504134449.64473-1-andriy.shevchenko@linux.intel.com>

Wow, MPC5200, that was a long time ago for me...

> It seems mpc52xx_get_xtal_freq() is not used anywhere. Remove dead code.

Looks like it.

Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature