> + qc = __ata_qc_from_tag(ap, tag); > + qc->tag = qc->hw_tag = tag; > + qc->scsicmd = NULL; > + qc->ap = ap; > + qc->dev = dev; > + > + ata_qc_reinit(qc); > + > + qc->scsicmd = cmd; My fault, byt we can remove the first qc->scsicmd a nothing looks at the field before this real initialization. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
