On 4/7/22 01:59, Limonciello, Mario wrote: > [Public] > > > >> -----Original Message----- >> From: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> >> Sent: Tuesday, April 5, 2022 21:11 >> To: Limonciello, Mario <Mario.Limonciello@xxxxxxx> >> Cc: open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers) <linux- >> ide@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>; >> hdegoede@xxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx> >> Subject: Re: [PATCH v2 2/2] ata: ahci: Rename CONFIG_SATA_LPM_POLICY >> configuration item back >> >> On 4/5/22 05:02, Mario Limonciello wrote: >>> CONFIG_SATA_LPM_MOBILE_POLICY was renamed to >> CONFIG_SATA_LPM_POLICY in >>> commit 4dd4d3deb502 ("ata: ahci: Rename >> CONFIG_SATA_LPM_MOBILE_POLICY >>> configuration item"). >>> >>> This caused some pain as users would invisibly lose configuration policy >>> defaults when they built the new kernel. To help alleviate that, switch >>> back to the old name (even if it's wrong). >>> >>> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx> >>> Suggested-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> >> >> I applied this manually as the "default 3" is from the first patch, >> which is for 5.19. This one is queued in for-5.18-fixes now. Thanks. > > Ah I didn't realize you were not going to put default 3 in 5.18, otherwise I would > have re-ordered them. Sorry. > > Which branch did you push what you've applied so far to? > I checked libata/for-next and libata/for-5.19 and didn't see anything yet. I pushed the patch to for-5.18-fixes and will send a PR to Linus tomorrow. The for-5.19 and for-next branches always are in sync and currently based on 5.18-rc1. I will rebase them on rc2 next week to have the name revert in and avoid conflicts. > > As most of my patches recently touch the same code want to me make sure > any more follow ups work from the right base. Use 5.19 + the name revert patch for your work. That will correspond to for-5.19 next week. -- Damien Le Moal Western Digital Research